Conversation
Also: * Optimize proto imports.
armiol
approved these changes
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the BuildSpeed project to Java 17, Kotlin 2.1.10, and Gradle 8.13. Other dependencies were also upgraded via applying the latest
config.Changes in details
Proto files were updated to by compatible with latest version of Base, in particular adding the
versionproperty for the(range)option.Mixin interfaces were added where a
java_typeoption was used only for one proto type. This was needed because we no longer generate single mix-in interfaces (because they don't have much sense).Unused proto imports were removed.
The
build.ymlworkflow got default versions of dependencies that are currently used in McJava.